Adopt new internal Search query shapes for new API shape #214041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
changed the title
andreamah
added a commit
that referenced
this pull request
Aug 13, 2024
Adopt new search query structure in preparation for new search API shapes. Pt 1 of trying to break down #214041 into smaller PRs. This will cause `beforeContext` to be ignored in the `findTextInFiles` API. This is because we will be using `surroundingContext` in the new API.
andreamah
commented
Aug 16, 2024
| }; | ||
|
|
||
| /** | ||
| * Exclude files larger than `maxFileSize` in bytes. | ||
| */ | ||
| maxFileSize: number; |
There was a problem hiding this comment.
changing these to be optional- the provider can enforce the default value if not set
andreamah
changed the title
bpasero
approved these changes
Aug 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating
Newversions of all Search APIs (ie:TextSearchProviderNew) to support the new API shape.Since this new shape requires a new internal query shape, this is quite a big change.
Here, we are doing Pt2 of changing the internal search implementation to allow Search APIs to follow these diagrams:
Later, I will convert the
Newtypes to just be overloads of the old proposed types for backward compatibility.From an outsider's perspective, this should not affect anything, except the search APIs that end in
Newwill work.