use chord instead of label #218107
Merged
use chord instead of label #218107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jun 25, 2024
| const keybinding = keybindings.find(kb => kb.getLabel() === 'Shift+Enter'); | ||
| const keybinding = keybindings.find(kb => { | ||
| const chords = kb.getDispatchChords(); | ||
| return chords.length === 1 && chords[0] === 'shift+Enter'; |
| const keybinding = keybindings.find(kb => kb.getLabel() === 'Shift+Enter'); | ||
| const keybinding = keybindings.find(kb => { | ||
| const chords = kb.getDispatchChords(); | ||
| return chords.length === 1 && chords[0] === 'shift+Enter'; |
There was a problem hiding this comment.
it's hard coded to 'shift'
src/vs/workbench/contrib/interactive/browser/replInputHintContentWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/interactive/browser/replInputHintContentWidget.ts
Outdated
Show resolved
Hide resolved
| let keybinding = keybindings.find(kb => { | ||
| const chords = kb.getDispatchChords(); | ||
| return chords.length === 1 && chords[0] === 'Enter'; | ||
| }); | ||
| if (keybinding) { | ||
| return keybinding; | ||
| } | ||
| keybinding = this.keybindingService.lookupKeybindings('python.execInREPLEnter') |
There was a problem hiding this comment.
Why are we looking up python. commands in core?
There was a problem hiding this comment.
python shadows the command for the REPL, this hint doesn't work correctly if we don't look it up, and the point is to make this clear for python/jupyter users
…entWidget.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Tyriar
approved these changes
Jun 25, 2024
bricefriha
pushed a commit
to bricefriha/vscode
that referenced
this pull request
Jun 26, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #217901
Dispatch cords are strings built from hard coded values, whereas labels are configured from an OS specific mapping.