-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menu bar extensions #7704
Merged
menu bar extensions #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
command can have one for context definition which denotes additonal places where they show in the UI under what condition...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is the start to implement #3192 by allowing extensions to add primary and secondary actions to the editor action bar. The approach we take will also allow to add action in other places, like viewlets or context menus.
The current thinking goes like this: In the
commands
contribution point will get an additionalcontext
property (better name to be found) that allows to define where to show the command under what condition.The sample above makes the command show up in the primary editor tool bar when it shows a typescript file. The
path
will be a finite enumeration of locations, likeeditor/primary
,editor/secondary
,explorer/primary
etc. Thewhen
condition is the trustworthy DocumentSelector always being applied on an Uri.The big concern is UI scalability wrt the amount of actions/menu entries accumulating over time. I don't think being restrictive is the right approach but we should give users the change to customise menus like we allow to customise keybindings. Customisation from extensions should be treated as proposed customisation which the user accepts or denies. Analog to keybindings, there should be a file like
menus.json
which allows to manually change the menu layout.