Implement support for master interface configuration in CNI config #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
master
field in CNI configuration was present in example configs but completely ignored by the parsing and network creation code. This PR implements proper support for themaster
field to specify the host interface that networks should bind to.Problem
The existing example configurations include a
master
field:However, the
NetworkConfig
struct did not include this field, and it was not used anywhere in the network creation process.Solution
Added
Master
field toNetworkConfig
struct with proper JSON tag:Updated
GetNetworkInfo()
method to use the master field:Added informative logging when master interface is specified
Maintained backward compatibility - configs without master field continue to work
Testing
The
InterfaceName
field was already supported by the HCN network creation code, so this change leverages existing infrastructure to make themaster
configuration functional.Fixes #100.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.