Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show source identifier with source list #1455

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Show source identifier with source list #1455

merged 1 commit into from
Sep 11, 2021

Conversation

florelis
Copy link
Member

@florelis florelis commented Sep 10, 2021 •
edited by ghost
Loading

  • Show source identifier when doing source list <name>. This can be useful for creating json files for import.
  • Get the source identifier when adding a REST source to ensure it is added to the sources yaml. We were getting it only when opening the source so it wouldn't get saved and could not show it with source list. Existing sources are not updated.
Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner September 10, 2021 23:08
yao-msft
yao-msft approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@florelis florelis merged commit 88a69d8 into microsoft:master Sep 11, 2021
@florelis florelis deleted the SourceId branch September 27, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florelis @yao-msft