Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Zen-Team.Zen-Browser version 1.0.0-a.28 #168940

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 24, 2024

Pull request has been created with komac v2.4.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) August 24, 2024 06:58
@UnownPlain
Copy link
Contributor

This package already exists (#168542). You should update the existing one.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 25, 2024

My bad. To be fair, Komac and @wingetbot did not give a warning, and a quick search of "Zen Browser" did not yield any results 😅

@UnownPlain
Copy link
Contributor

It looks like this package installs the generic version while the optimized version is a separate package (#168942). I think it makes more sense to have this be the optimized version and the generic version be in a separate package since most systems should support the faster optimized version.

See: https://docs.zen-browser.app/guides/generic-optimized

The optimized version is supported in all systems with an Intel 4th Gen+ CPU and all Ryzen CPUs.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 25, 2024

It looks like this package installs the generic version while the optimized version is a separate package (#168942). I think it makes more sense to have this be the optimized version and the generic version be in a separate package since most systems should support the faster optimized version.

See: docs.zen-browser.app/guides/generic-optimized

The optimized version is supported in all systems with an Intel 4th Gen+ CPU and all Ryzen CPUs.

I'm following the AUR here (zen-browser-bin and zen-browser-optimized-bin), which makes sense since "optimized" is a "specific build" and the main package is expected to work for all. I still even have a laptop that doesn't support the "optimized" build (Yeah, old. But there are still a majority of people, especially in a third-world country, with a low-spec device).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 26, 2024
@stephengillie stephengillie removed Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Aug 26, 2024
@stephengillie
Copy link
Collaborator

Verify:
image
image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4206bb4 into microsoft:master Aug 26, 2024
8 checks passed
Copy link
Contributor

Hello sitiom,
Validation has completed.

Template: msftbot/validationCompleted

@sitiom sitiom deleted the Zen-Team.Zen-Browser-1.0.0-a.28-804C723BB6D6467AA22B04983023BBE1 branch August 27, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants