Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PuTTY.PuTTY 0.78.0.0: set UpgradeBehavior: uninstallPrevious #87021

Merged
1 commit merged into from
Nov 5, 2022
Merged

PuTTY.PuTTY 0.78.0.0: set UpgradeBehavior: uninstallPrevious #87021

1 commit merged into from
Nov 5, 2022

Conversation

kevinoid
Copy link
Contributor

@kevinoid kevinoid commented Oct 31, 2022 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

The PuTTY Change Log notes that

installing the 0.78 or later Windows installer will not automatically uninstall 0.77 or earlier, due to a change we've made to work around a bug. We recommend uninstalling the old version first, if possible. If both end up installed, uninstalling both and then re-installing the new version will fix things up.

Therefore, this PR sets UpgradeBehavior: uninstallPrevious so that any previous version will be uninstalled before upgrading to 0.78.

Thanks,
Kevin

Microsoft Reviewers: Open in CodeFlow

@kevinoid
PuTTY.PuTTY 0.78.0.0: set UpgradeBehavior: uninstallPrevious
dc564e9 
The [PuTTY Change Log] notes that

> installing the 0.78 or later Windows installer will not automatically
> uninstall 0.77 or earlier, due to a change we've made to work around a
> bug. We recommend uninstalling the old version first, if possible. If
> both end up installed, uninstalling both and then re-installing the
> new version will fix things up.

Therefore, set `UpgradeBehavior: uninstallPrevious` so that any previous
version will be uninstalled before upgrading to 0.78.

[PuTTY Change Log]: https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Hello @kevinoid,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Nov 1, 2022
@ghost ghost added the Retry-1 flag to indicate retried label Nov 1, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 1, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Hello @kevinoid,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Nov 1, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 1, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 1, 2022

kevinoid,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@Romanitho
Copy link

+1

@kevinoid kevinoid mentioned this pull request Nov 1, 2022
Merged
5 tasks
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 5, 2022
@ghost
Copy link

ghost commented Nov 5, 2022

Hello kevinoid,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit ef6bbb9 into microsoft:master Nov 5, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@mdanish-kh mdanish-kh mentioned this pull request Nov 28, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevinoid @wingetbot @Romanitho @Trenly @AmelBawa-msft @stephengillie