-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leveraging VS Code Source Control for GIT and GitHub #155
base: main
Are you sure you want to change the base?
Conversation
@ryihan @alfredodeza please what is the update on this? |
This looks like a great addition. Apologies for not reviewing before. @abrilurena can you take another extra look? |
Thanks for this, can't wait seeing it getting merge👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Taiwrash! I hope you're doing great. Thank you for your time, patience and for contribuiting to this repository! ❤️ ✨ I made some suggestions and changes to your files, please let me know if you have any questions. 😄
Files with requested changes:
- slides.pptx
- readme.md
- workshop-designer.md
full/leveraging-vscode-source-control-for-git-and-github/README.md
Outdated
Show resolved
Hide resolved
full/leveraging-vscode-source-control-for-git-and-github/README.md
Outdated
Show resolved
Hide resolved
|
||
## Video walk-through | ||
|
||
[![workshop walk-through](./images/promo.png)](https://youtu.be/_6B7Qa6-8j4 "workshop walk-through") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! I think including a gif would be awesome - it's easy for ambassadors to know that this is a video rather than an image. Please, click here for references.
When the requested changes have been made to your presentation (slides), please update your video. I suggest that it should be a 5-10 minute video that guides the audience (students ambassadors) to your workshop, what they will learn and how they can use it.
[![workshop walk-through](./images/promo.png)](https://youtu.be/_6B7Qa6-8j4 "workshop walk-through") | |
[![workshop walk-through](./images/promo.png)](https://youtu.be/_6B7Qa6-8j4 "workshop walk-through") |
full/leveraging-vscode-source-control-for-git-and-github/README.md
Outdated
Show resolved
Hide resolved
full/leveraging-vscode-source-control-for-git-and-github/README.md
Outdated
Show resolved
Hide resolved
full/leveraging-vscode-source-control-for-git-and-github/README.md
Outdated
Show resolved
Hide resolved
- Remote | ||
|
||
|
||
### Introducing VS Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the section in which you begin practicing, I think it would be great if you included a corresponding title because it can be confused with the previous section.
full/leveraging-vscode-source-control-for-git-and-github/README.md
Outdated
Show resolved
Hide resolved
| ------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------- | | ||
| **What will you learn** | Students will be skilled at creating using VS Code Source Control to create, rename, switch and merge branches, add, commit and even publish to GitHub | | ||
| **What you'll need** | [Visual Studio Code](https://code.visualstudio.com?WT.mc_id=academic-56602-chrhar) and [Git](https://git-scm.com/) | | | ||
| **Slides** | [Powerpoint](./slides.pptx) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about the slides:
- Slide # 2: needs to be removed because it's from a different workshop and it can confuse students.
- slide # 6 : suggestion on your notes, this could be said in a friendlier way, I recommed that you use WordTune to improve your message.
- Slide # 9 : it would be better if it's not included in the slides, so this can help to create a more inclusive and friendly environment to everyone.
- about your notes on slide 12: i think this sentence looks pretty similar to the explanation you have on slide 13
- notes on slide 15: I recommend you use Wordtune, it will greatly enhance the clarity of your messages.
- about slide 17: there is a word missing in the second sentence and I suggest to use Wordtune or grammarly to help you 😄
- about slide 18: grammar here, you can see if you copy/paste your text on a Word file. Also, Grammarly can help you too 😄
- about slide 19: this sentence is a bit confusing 👀
- about slide 20: it would be better to remove the sentences that are in the yellow highlighter.
- about slide 29: I recommend you use Wordtune, it will greatly enhance the clarity of your messages.
- about slide 30: If you would like this link to be included on the slides (yellow highlighter)
it would be necessary to remove this sentence (blue highlighter). My advice is that you also use Grammarly and WordTune to review it.
Since it seems that each section is different, adding a title here will make it easier for the audience to understand.
- about slide 31: i believe it would be better to change "shout out!" to "feedback" 😄
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…s/Animated YouTube Channel Art Template - Made with PosterMyWall.mp4
@alfredodeza @ryihan @abrilurena @videlalvaro all corrections made. Thanks... |
…hop-designer.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
…E.md Co-authored-by: Abril Ureña <107883174+abrilurena@users.noreply.github.com>
Welcome to the new year, This issue has been the pipeline for long (close to 2 years). Can you all help me out with this, this means a lot to the impact I want to make in the community. Thanks @alfredodeza @ryihan @abrilurena @videlalvaro Looking forward to your reviews.. |
Use this template to add a workshop to this repo. Add the following items:
Your workshop design document, filled in with some details about your proposed workshop including its title and the three stages in the designer delineated, using the
workshop-designer.md
file in the template.A
README.md
file that describes the steps of the workshop.Powerpoint Slides for the workshop.
The workshop's solution in the
/solution
folder.An embedded Train the Trainer video.
A Call to Action to enhance the workshop with a direct line to Microsoft Learn by linking to an appropriate Learn module.
Code quality check: no authentication keys should be included in solution or sample code
A reviewer will be assigned to the workshop and will work with you to shape it for production. Thank you for your contribution!
To fix #151 issue