Skip to content
This repository was archived by the owner on Jun 20, 2022. It is now read-only.

Conversation

irvinesunday
Copy link

Issue:
Operation tags for media entity navigation property paths of EntitySet navigation sources don't match their parents' tags e.g. /users/{id}/photo/$value tag is users.user, yet /users/{id}/photo tag is users.profilePhoto.

MicrosoftTeams-image (5)

Fix:
This PR appropriately fixes the condition evaluating whether a media entity path is a navigation property path when creating tags.

Below are a few snippet of the operation tags generated from this fix:

/users({id})/photo/$value:
    get:
      tags:
        - users.profilePhoto
      summary: Get media content for the navigation property photo from users
      operationId: users.GetPhotoContent
/users({id})/contacts({id1})/photo/$value:
    get:
      tags:
        - users.contacts.profilePhoto
      summary: Get media content for the navigation property photo from users
      operationId: users.contacts.GetPhotoContent
/groups({id})/onenote/pages({id1})/content:
    get:
      tags:
        - groups.onenote.onenotePage
      summary: Get media content for the navigation property pages from groups
      operationId: groups.onenote.GetPagesContent

Here's a link to the complete v1.0 OpenAPI doc. generated from this fix: https://microsoft.sharepoint-df.com/:u:/t/GraphTooling/Efkqll2yap9GloX3nPMM38YBcAd-jmAZKG3fQeKIHscghg?e=FKjVHn

Fixes the condition evaluating whether a path has navigation property segments.
@irvinesunday irvinesunday added the bug Something isn't working label Oct 14, 2020
@irvinesunday irvinesunday self-assigned this Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants