This repository was archived by the owner on Jun 20, 2022. It is now read-only.
forked from microsoft/OpenAPI.NET.OData
-
Notifications
You must be signed in to change notification settings - Fork 1
Fix: Update /$ref update operation from PATCH to PUT #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddyett
reviewed
Aug 11, 2020
src/Microsoft.OpenApi.OData.Reader/Operation/OperationHandlerProvider.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Aug 11, 2020
test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/Multiple.Schema.OpenApi.json
Outdated
Show resolved
Hide resolved
peombwa
reviewed
Aug 11, 2020
src/Microsoft.OpenApi.OData.Reader/Operation/OperationHandlerProvider.cs
Show resolved
Hide resolved
peombwa
reviewed
Aug 11, 2020
src/Microsoft.OpenApi.OData.Reader/Operation/RefPostOperationHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
peombwa
reviewed
Aug 11, 2020
src/Microsoft.OpenApi.OData.Reader/Operation/RefPostOperationHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
peombwa
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoftgraph/microsoft-graph-explorer-api/issues/291
Proposes:
/$ref
paths fromPATCH
toPUT
. See documentation.RequestBody
schema from typestring
toobject
since it will be a key-value pair representation. See documentation.