Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: open file/folder in new window when you press enter/backspace on it #2325

Merged
merged 4 commits into from
May 30, 2023
Merged

fix: open file/folder in new window when you press enter/backspace on it #2325

merged 4 commits into from
May 30, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented May 17, 2023

Closes #2319

PR Type

  • Bugfix

Description of the changes

Opens a file/folder in a new window when it is focused and you press enter/backspace key.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved-->
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale
Open file/folder when you press enter/backspace on focused item
2f2259f 
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
@musale musale added this to the v3.0.0 milestone May 17, 2023
@musale musale requested a review from vagpt May 17, 2023 14:04
@musale musale requested a review from a team as a code owner May 17, 2023 14:04
@ghost
Copy link

ghost commented May 17, 2023

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@musale musale linked an issue May 17, 2023 that may be closed by this pull request
[MGTP-Left Navigation- Mgt-file-list-File List]: 'Attachments' list item under ‘File List’ page is not actionable when user try to activate using enter/spacebar key. #2319
Closed
@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@gavinbarron
Copy link
Member

@vagpt and @KarunaNarang this item is ready for review.

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@musale musale merged commit e7efa21 into next/fluentui May 30, 2023
8 checks passed
@musale musale deleted the ac11y-2319 branch May 30, 2023 12:05
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@Mnickii Mnickii Mnickii approved these changes

@vagpt vagpt Awaiting requested review from vagpt

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
v3.0.0
3 participants
@musale @gavinbarron @Mnickii