Additional test coverage

microsoftgraph · Jul 31, 2023 · 2094efa · 2094efa
1 parent aa7d025
commit 2094efa
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/Models/SearchQuery.cs b/src/Models/SearchQuery.cs
@@ -12,7 +12,7 @@ public SearchQuery()
       this.Request = new RequestProperties();
     }
 
-    public SearchQuery(string queryText, List<string> selectProperties = null, List<Sort> sortList = null, long? startRow = null, int? rowLimit = null, int? rowsPerPage = null, bool? trimDuplicates = false)
+    public SearchQuery(string queryText, List<string> selectProperties = null, List<Sort> sortList = null, long? startRow = null, int? rowLimit = null, int? rowsPerPage = null, bool? trimDuplicates = null)
       : this()
     {
       this.Request.Querytext = queryText;

diff --git a/src/Serializer/SPSearchQueryConverter.cs b/src/Serializer/SPSearchQueryConverter.cs
@@ -53,10 +53,6 @@ public override void Write(Utf8JsonWriter writer, SearchQuery value, JsonSeriali
       {
         requestObjectToSerialize.TrimDuplicates = value.Request.TrimDuplicates.Value;
       }
-      else
-      {
-        requestObjectToSerialize.TrimDuplicates = false;
-      }
 
       var objectToSerialize = new
       {

diff --git a/test/SearchQueryModelTests.cs b/test/SearchQueryModelTests.cs
@@ -56,6 +56,16 @@ public static IEnumerable<object[]> GetSearchQueries()
         new SearchQuery("sharepoint", sortList: new List<SearchQuery.Sort> { { new SearchQuery.Sort{ Property="[docid]", Direction=SearchQuery.SortDirection.Ascending} } }),
         "{\"request\":{\"Querytext\":\"sharepoint\",\"SortList\":{\"results\":[{\"Property\":\"[docid]\",\"Direction\":\"0\"}]}}}"
       };
+      yield return new object[]
+      {
+        new SearchQuery("sharepoint", new List<string> { "Title", "Path" }, trimDuplicates: false),
+        "{\"request\":{\"Querytext\":\"sharepoint\",\"SelectProperties\":{\"results\":[\"Title\",\"Path\"]},\"TrimDuplicates\":false}}"
+      };
+      yield return new object[]
+      {
+        new SearchQuery("sharepoint", new List<string> { "Title", "Path" }, trimDuplicates: true),
+        "{\"request\":{\"Querytext\":\"sharepoint\",\"SelectProperties\":{\"results\":[\"Title\",\"Path\"]},\"TrimDuplicates\":true}}"
+      };
     }
 
     [Theory]