Skip to content

Eliminate all CS8618, CS0618, and ASP0019 compiler warnings #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

Eliminate all CS8618, CS0618, and ASP0019 compiler warnings #7048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a4e4c0
Initial plan
Copilot Oct 2, 2025
8326f90
Fix all warnings: non-nullable properties, obsolete methods, and head…
Copilot Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eFormAPI/eFormAPI.Web/Controllers/Eforms/AudioController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public async Task<IActionResult> GetAudio(string fileName)
// new MediaTypeHeaderValue("application/octet-stream");
//result.Content.Headers.ContentLength = stream.Length;
//result.Content.Headers.ContentRange = new ContentRangeHeaderValue(0, stream.Length);
Response.Headers.Add("Accept-Ranges", "bytes");
Response.Headers["Accept-Ranges"] = "bytes";
Response.Headers.Remove("Cache-Control");
return File(stream, "audio/wav");
}
Expand Down
4 changes: 2 additions & 2 deletions eFormAPI/eFormAPI.Web/Hosting/Security/ClaimsTransformer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public async Task<ClaimsPrincipal> TransformAsync(ClaimsPrincipal principal)

if (auth == null)
{
_httpContextAccessor.HttpContext.Response.Headers.Add(AuthConsts.UpdateHeaderName, AuthConsts.UpdateHeaderValue);
_httpContextAccessor.HttpContext.Response.Headers[AuthConsts.UpdateHeaderName] = AuthConsts.UpdateHeaderValue;
}
else
{
Expand All @@ -86,7 +86,7 @@ public async Task<ClaimsPrincipal> TransformAsync(ClaimsPrincipal principal)

if (timeValue != auth.TimeStamp)
{
_httpContextAccessor.HttpContext.Response.Headers.Add(AuthConsts.UpdateHeaderName, AuthConsts.UpdateHeaderValue);
_httpContextAccessor.HttpContext.Response.Headers[AuthConsts.UpdateHeaderName] = AuthConsts.UpdateHeaderValue;
}

// Add claims
Expand Down
6 changes: 3 additions & 3 deletions ...PI/eFormAPI.Web/Infrastructure/Models/SelectableList/AdvEntitySelectableGroupEditModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ namespace eFormAPI.Web.Infrastructure.Models.SelectableList;

public class AdvEntitySelectableGroupEditModel
{
public string Name { get; set; }
public string GroupUid { get; set; }
public string Description { get; set; }
public required string Name { get; set; }
public required string GroupUid { get; set; }
public required string Description { get; set; }
public List<EntityItem>? EntityItemModels { get; set; }
}
2 changes: 1 addition & 1 deletion eFormAPI/eFormAPI.Web/Services/WordProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void AddHtml(string html)
}

var converter = new HtmlConverter(mainPart);
converter.ParseHtml(html);
converter.ParseBody(html);
mainPart.Document.Save();
}

Expand Down