Add ESLint and scss-lint configurations and fix some (many) lint errors

.eslintignore

@@ -0,0 +1,12 @@
+# Midas Server. Copyright Kitware SAS. Licensed under the Apache License 2.0.
+
+**/*.min.js
+**/jqplot*.js
+**/jquery*.js
+bower_components/
+library/SwaggerUI/
+modules/{pvw,visualize}/public/js/jquery/colorpicker.js
+modules/statistics/public/js/googlemaps/*.js
+modules/visualize/public/js/{paraview,webgl}/*.js
+node_modules/
+vendor/

.eslintrc

@@ -0,0 +1,43 @@
+#=============================================================================
+# Midas Server
+# Copyright Kitware SAS, 26 rue Louis Guérin, 69100 Villeurbanne, France.
+# All rights reserved.
+# For more information visit http://www.kitware.com/.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0.txt
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#=============================================================================
+
+---
+rules:
+  indent:
+    - 2
+    - 4
+  quotes:
+    - 2
+    - single
+  linebreak-style:
+    - 2
+    - unix
+  semi:
+    - 2
+    - always
+
+  no-unused-vars:
+    - 2
+    - argsIgnorePattern: ^_
+
+env:
+  browser: true
+  jquery: true
+
+extends: 'eslint:recommended'

.scss-lint.yml

@@ -0,0 +1,55 @@
+#=============================================================================
+# Midas Server
+# Copyright Kitware SAS, 26 rue Louis Guérin, 69100 Villeurbanne, France.
+# All rights reserved.
+# For more information visit http://www.kitware.com/.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0.txt
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#=============================================================================
+
+---
+scss_files: '**/public/scss/*.scss'
+
+exclude:
+  - '**/public/**/*.css'
+  - 'core/public/scss/mixins/**'
+  - 'library/SwaggerUI/**'
+  - 'vendor/**'
+
+linters:
+  ColorVariable:
+    enabled: false
+
+  HexNotation:
+    style: uppercase
+
+  IdSelector:
+    enabled: false
+
+  ImportantRule:
+    enabled: false
+
+  Indentation:
+    width: 4
+
+  NestingDepth:
+    max_depth: 4
+
+  QualifyingElement:
+    enabled: false
+
+  SelectorDepth:
+    max_depth: 4
+
+  SelectorFormat:
+    convention: camel_case

core/public/css/admin/admin.upgrade.css

@@ -1 +1 @@
-div.viewSideBar input.globalButton{margin-left:0 !important;}
+div.viewSideBar input.globalButton{margin-left:0 !important}

core/public/css/assetstore/assetstore.movedialog.css

@@ -1 +1 @@
-div.bottomButtons{margin-top:15px;float:right;}#moveBitstreamsProgressBar{margin-bottom:6px;margin-top:6px;}
+div.bottomButtons{float:right;margin-top:15px}#moveBitstreamsProgressBar{margin-bottom:6px;margin-top:6px}

core/public/css/community/community.invitation.css

@@ -1 +1 @@
-input#urlInput{width:300px;}div#permissionsContent a{color:#56758b;cursor:pointer;font-weight:500;text-decoration:none;}div#permissionsContent a:hover{text-decoration:underline;}#live_invitation_search{width:100%;}
+input#urlInput{width:300px}div#permissionsContent a{color:#56758b;cursor:pointer;font-weight:500;text-decoration:none}div#permissionsContent a:hover{text-decoration:underline}#live_invitation_search{width:100%}

core/public/css/community/community.promotedialog.css

@@ -1 +1 @@
-input.addToGroupsSubmit{float:right;}img#promoteDialogLoading{float:left;}
+input.addToGroupsSubmit{float:right}img#promoteDialogLoading{float:left}

core/public/css/community/community.selectgroup.css

@@ -1 +1 @@
-div.bottomButtons{float:right;margin-top:13px;}#groupSelect{margin-top:10px;width:100%;}
+div.bottomButtons{float:right;margin-top:13px}#groupSelect{margin-top:10px;width:100%}

core/public/css/error/error.error.css

@@ -1 +1 @@
-div.errorMessage{margin-bottom:10px;margin-top:5px;}div.exceptionText{margin-top:20px;}
+div.errorMessage{margin-bottom:10px;margin-top:5px}div.exceptionText{margin-top:20px}

core/public/css/feed/feed.index.css

@@ -1 +1 @@
-div.feedThumbnail img{display:none;height:31px;margin-right:4px;width:31px;}div.feedThumbnail a{border:0;}
+div.feedThumbnail img{display:none;height:31px;margin-right:4px;width:31px}div.feedThumbnail a{border:0}

core/public/css/folder/folder.createfolder.css

@@ -1 +1 @@
-form#editFolderForm input[type="text"],form#editFolderForm input[type="password"]{width:350px !important;}form#editFolderForm textarea{width:350px !important;}
+form#editFolderForm input[type='text'],form#editFolderForm input[type='password']{width:350px !important}form#editFolderForm textarea{width:350px !important}