This repository was archived by the owner on Sep 10, 2021. It is now read-only.
Fix submission producer create #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix logic around producer and trendgroup deletion.
Applied fixes from StyleCI
|
@mgrauer PTAL. |
|
Very nice. Can you changes these docblock comments on the submission.add API endpoint? They are out of sync with the submission POST endpoint that submission.add forwards on to. Also mention that write access on the community is required, similar to scalarAdd, in the submission.add function description. Otherwise LGTM. |
|
@cpatrick PTAL. This is good from my end. |
|
Your changes lgtm. I'll merge once Travis is happy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.