Skip to content
This repository was archived by the owner on Sep 10, 2021. It is now read-only.

Applied fixes from StyleCI #241

Merged
merged 1 commit into from
May 11, 2016
Merged

Applied fixes from StyleCI #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/tracker/controllers/SubmissionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ public function csvAction()
$daysInterval = $daysInterval ? $daysInterval : false;
$results = $this->Tracker_Submission->getTabularSubmissionDetails($producerDao, $submissionDao, $keyMetrics, $daysInterval);

$output = fopen("php://output", 'w') || exit("Can't open php://output");
$filename = 'producer_' . $submissionDao->getProducerId() . '_' . $submissionDao->getUuid() . '.csv';
$output = fopen('php://output', 'w') || exit("Can't open php://output");
$filename = 'producer_'.$submissionDao->getProducerId().'_'.$submissionDao->getUuid().'.csv';
header('Content-type: application/csv');
header('Content-Disposition: attachment; filename="'.$filename.'"');
/** @var array $resultsRow */
Expand Down
3 changes: 2 additions & 1 deletion modules/tracker/models/pdo/SubmissionModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public function getTabularSubmissionDetails($producerDao, $submissionDao, $key =
'branch' => $submissionDao->getBranch(),
);
$colHeaders = array(
'uuid', 'producer_revision', 'submit_time', 'metric_name', 'test_dataset_name', 'value', 'unit'
'uuid', 'producer_revision', 'submit_time', 'metric_name', 'test_dataset_name', 'value', 'unit',
);
$results[] = array_merge(array_keys($invariantCols), $colHeaders);
$rows = $this->database->fetchAll($sql);
Expand All @@ -409,6 +409,7 @@ public function getTabularSubmissionDetails($producerDao, $submissionDao, $key =
}
$results[] = $resultRow;
}

return $results;
}

Expand Down