This repository was archived by the owner on Sep 10, 2021. It is now read-only.
Consume tracker producer #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
July 28, 2016 20:37
Applied fixes from StyleCI
Applied fixes from StyleCI
…definition submission
Applied fixes from StyleCI
|
@cpatrick PTAL |
| $trendModel->setAggregatableTrendAsKeyMetrics($producerDao, $keyMetric->name); | ||
| $trendThresholdModel->upsert($producerDao, $keyMetric->name, | ||
| isset($keyMetric->abbreviation) ? $keyMetric->abbreviation : false, | ||
| isset($keyMetric->warning) ? $keyMetric->warning : |
There was a problem hiding this comment.
I have a fear of nested ternaries (I was bitten as a child). Could you create a more clear helper function and use that here rather than the nested ternaries?
|
Very nice. Once nit and LGTM! |
added 3 commits
August 3, 2016 16:12
|
@cpatrick nit picked. |
|
Much better. LGTMWTIH. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.