-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT on Odroid XU4 #149
Comments
@bspinner |
Hey, nice to come back to this repo and see a lot of changes. Thanks for your hard work! :) See #223 for problems I'm currently experiencing. |
@bspinner |
@bspinner Try adding |
Well, actually I am getting a crash without the flag when I press Start. gdb output, segfault again:
Will rebuild with |
@bspinner |
(it's the latest ubuntu 16.04 as provided by hardkernel) |
Something else I noticed: the GUI isn't scaled to fullscreen anymore. Is that on purpose/do I have to configure something? |
@bspinner On the RPI, there's the notion of different gfx drivers (Legacy, fkms, full KMS). Depending on which one is enabled, and what configuration options you provide in SDL2 before building it, the behavior will be different. I'm not sure how it looks on the XU4, but if you try a |
@bspinner |
|
@bspinner |
and pkg-config!
…On Thu, Feb 1, 2018 at 11:44 PM, Dimitris Panokostas < ***@***.***> wrote:
@bspinner <https://github.com/bspinner>
OK, no KMSDRM support from what it seems... Do you have libgles2-mesa-dev
and libgbm-dev installed? I believe those are a requirement for KMSDRM...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-P6ItWwy1Ef8xi7X6VtJOKAgjgHOhUks5tQj5GgaJpZM4QVOc9>
.
|
Rebuild SDL2 with kmsdrm support, still not working. |
@bspinner Once you run it, it will display an image. You can quit from it with the "Q" button on the keyboard. |
|
@midwan Any other ideas? Is KMS/DRM actually neccessary to use amiberry now? |
@bspinner Are you trying to launch it from the console or under X11? |
@midwan |
@bspinner |
@midwan Is there some way to get more info out of SDL/amiberry than just a crash?
Do I have to compile SDL with debug symbols or something like that? |
@bspinner The only recent change I made regarding graphics in SDL2, was the option to use Fullscreen or Windowed mode. But with the latest updates, it tries to detect if it's running under " From what I can see in your test, you have opengles2 support. When you run the test application, did you also see the window open up, with the Amiberry logo showing? Was that fullscreen as expected? |
Summary:
Log:
|
That Config file is full of a lot of old info. It should be replaced with a fresh own starting from the QuickStart option as the base. Delete the uaeconfig.uae file first of all I think! |
That's worth a try for sure, also if you have an older I originally suspected the JIT FPU code, but with the above log it seems you haven't got JIT enabled, so it can't be that... |
Still crashes. :( Used A1200 quick start config this time.
|
So, the crash moved from sdl's library to
|
@bspinner You'll need to do a |
I've changed the noted below lines and recompiled by
Crash seems to be the same:
|
@bspinner |
I don't know the commit hash, but binary's timestamp is |
@bspinner |
@midwan hmm.. I think this will be straight forward.. I'll try myself to come up with a little hacky script :) |
@midwan Weeeell, bisect result is either |
@bspinner |
Didn't have much time on my hands for this today. But at least I can be sure that the bug we're looking for didn't start at |
Unfortunately it's not that easy to create a proper test script due to the many changes made to the Makefile, UAE config structure etc. @midwan I've started over with latest dev commit and this was the output
Made with log
|
@bspinner If it's what I think it is, it's related to the new FPU JIT code and specifically the part trying to save the registers. We are using assembly to do that, but perhaps that doesn't work on the XU4. I'll update that part with C++ code instead to see if it works for you. |
@bspinner I'm attaching a modified version of newcpu.cpp, could you place this into your src/ directory and recompile, then test it? |
It works! Awesome 👍 So back to the actual content of this issue.. I'll test JIT now. |
Excellent, I'll add that in the dev branch and it will get merged into master eventually. I'll also follow a similar pattern for the other assembly functions, that might cause problems like this on other platforms. |
Observations:
|
@bspinner I'll have to test the same configuration on the RPI to see if it also fails, is that Lotus image available somewhere so I can test in the same (it could be related to that version also)? Edit: Also, I noticed you're using an A4000 ROM with an A1200 config? |
Except 3D games ;) |
Lotus turbo challenge 2 aga version by Krypt. A4000 Rom with a 1200 shouldn't be the case. I checked everything twice. Hm. I'll look into it when I'm at home. |
Just a note, there is no AGA version of any Lotus games. That just means it's fixed to work on AGA machines. |
@ZappaUtopia Well, if we start nitpicking: actually those fixed games are AGA (compatible) versions. But yes, there are no official AGA versions with fancier graphics or anything alike by the original developer. :) @midwan The results are the same with a clean A1200 configuration. Just recompiled latest The H3 error mentioned in first post seems to be gone though. It's either crashing "in emulation" with a guru meditation (forgot to take note on the code...) or crashing the whole emulator. |
@bspinner
everything else defaults as set from the Quickstart (no JIT). It seems to work fine on that board at least. No crashes, no H3 error. |
@bspinner But like I said, most games should not have JIT enabled anyway... |
@midwan Hmm... it's up to you whether you want to take a deeper look into this or not. :) |
JIT on Odroid XU4 seems to be broken. As mentioned here, it's failing at boot time for A4000 configurations. Other models aren't stable either.
Symptoms:
A4000 3.x kickstarts do not boot, when JIT is enabledfixedMost of the times error codeH10
is displayed in red status barSometimes Too many access violations. Please turn off dialog appearsLogs:
uae4arm_log.accessviolation.txtuae4arm_log.h10.txt#149 (comment)
The text was updated successfully, but these errors were encountered: