Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ask permission before phoning home #1418

Closed
4 tasks done
older-pack opened this issue Jan 10, 2023 · 8 comments
Closed
4 tasks done

Please ask permission before phoning home #1418

older-pack opened this issue Jan 10, 2023 · 8 comments

Comments

@older-pack
Copy link

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Description

When I launched the Linux appimage for the first time it phoned home to these domains:

api.github.com
redirector.gvt1.com
losslesscut.mifi.no

Would it be possible to ask the user's permission first?

I think the redirector.gvt1.com domain might be linked to a spell check dictionary service in Electron.
I guess that service probably isn't used by LosslessCut and could be disabled like it was here in bitwarden

Thanks for LosslessCut. Very cool app.

@mifi
Copy link
Owner

mifi commented Jan 13, 2023

Hi!
These endpoints are used for showing some dynamic content as well as checking for updates. It's definitely possible, but definitely not my highest priority to implement. Can leave this request open though.
See also #457 #1055

@older-pack
Copy link
Author

older-pack commented Jan 13, 2023

Hi,
Thanks for replying.

I know I'm not going to change your mind but here are some thoughts.

I dislike big tech spying on users.
And that's why I love open source software.

I think the 'dynamic content' is an unnecessary taint on an otherwise great app.
I don't believe you're harvesting user data like big tech, but even getting a user's IP address (without permission) is too much data for me.

I've no objection to you hard coding messages about your other apps and services and/or the Ukrainian flag.
I just don't like the 'dynamic' part without asking.

Do your messages really have to be dynamic?
Could you not change them in each new updated version of LosslessCut?

As for updates, it was always traditional to ask the user if they wanted to check for them.

Thanks for listening and being open about it and for leaving the issue open.

Great app.

@mifi
Copy link
Owner

mifi commented Jan 15, 2023

I think a lot of apps these days make some kind of network requests automatically. Heck some even require logging in to a service before using. In an ideal world, yea, all apps would be strictly offline, until the user needs something online. Hopefully in the future, all popular operating systems will automatically start asking dialog popups like Do you want to allow app XX to access the internet? once an app tries to make a network request, kind of like how many OS's (like macos) now will not allow apps to access a user's files without the user confirming a popup dialog. Until then, I'm not sure, but I will keep this request in mind. Would a CLI flag to disable all network traffic be a good alternative? It would be the easiest to implement.

@mifi
Copy link
Owner

mifi commented Jan 15, 2023

next version will allow turning off auto updates

mifi added a commit that referenced this issue Jan 15, 2023
@older-pack
Copy link
Author

In an ideal world, yea, all apps would be strictly offline, until the user needs something online.

That ideal world was circa 2005... I remember it well. Those were the days. 😉 😀

Would a CLI flag to disable all network traffic be a good alternative?

Anything would be better than nothing.
Thanks again.

@Jookia
Copy link

Jookia commented Feb 7, 2023

You can revoke the network permission using Flatseal

@mifi
Copy link
Owner

mifi commented Feb 16, 2023

next version will have a flag --disable-networking that will disable update check and other networking. will close this for now then

@mifi mifi closed this as completed in bc4edf9 Feb 16, 2023
@older-pack
Copy link
Author

@Jookia Thanks. Never heard of Flatseal before. Looks very useful.

@mifi Thanks for listening and making the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants