Add style linter #13
Add style linter #13
Conversation
|
Thanks for your pull request. This PR has merge conflicts - can you resolve them? I will merge it after that. ;-) |
- add two scripts to execute eslint
maal26
force-pushed
the
feature/add-style-linter
branch
from
001dccf
to
bf349c1
Compare
|
Ok, it's done. Let me know if you need anything changed. |
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 4 |
There was a problem hiding this comment.
NAB: Just a opinion that should be open to discussion with the owner, airbnb-base uses indent_size = 2.
There was a problem hiding this comment.
My current IDE settings using 4 by default for javascript. So, that's ok for me.
| "env": { | ||
| "es6": true | ||
| }, | ||
| "extends": ["eslint:recommended"], |
There was a problem hiding this comment.
NAB: should consider and discuss other extensions, personally I use airbnb-base and prettier which are very opinionated.
There was a problem hiding this comment.
I work more with PHP than with Javascript. Therefore, I do not know the most extensions and standards. You are free to create a pull request if you can optimize something. ;-)
related #9
This PR will add some config files to guarantee that all developers follow the same code style guide
The config files are: