Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Complete #40

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Project Complete #40

wants to merge 59 commits into from

Conversation

miguelesco
Copy link
Owner

@miguelesco miguelesco commented Sep 9, 2021

What's new

  • Create React App.
  • Install React-Redux, Redux Logger, and React Router.
  • Download the free image for the app logo.
  • Create routes and view components (Rockets, Missions, My Profile). Use for the page navigation links and style active class to indicate which section/page the user is currently on (underline active navigation link).
    -Create directories for all Redux state slice files (rockets, missions).

Live Preview

https://miguelesco.github.io/space-travelers/#/

Explaining video

https://drive.google.com/file/d/19v2qmLicQpC1iwcgVnjCYieaM2OXJ-M-/view?usp=sharing

carloso0114 and others added 25 commits September 7, 2021 17:32
New Feature Rockets Reservation
New Feature Display Reserved Rockets in Profile
Copy link

@AshakaE AshakaE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @miguelesco & @carloso0114 🙋‍♀️,

Great job so far! 👌
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Git flow ✔️
  • Organized readme ✔️
  • Pull request ✔️
  • tests ❌

Required Changes ♻️ 🚧

  • Kindly work on writing the unit tests for your application, at the moment you have no tests 🤔🙄

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Davidosky007
Copy link

Hi @miguelesco @carloso0114 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants