-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Complete #40
base: main
Are you sure you want to change the base?
Project Complete #40
Conversation
New Feature Navigation
Profile feature
Missions page set up
New feature Rockets component
New feature Featch Date of Rockets
Fetch missions
Display missions
New Feature Rockets Reservation
New Feature Display Reserved Rockets in Profile
New Feature Switch badges
Joining/leaving mission
Switch badges for missions
…file Display joined missions in profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @miguelesco & @carloso0114 🙋♀️,
Great job so far! 👌
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Git flow ✔️
- Organized readme ✔️
- Pull request ✔️
- tests ❌
Required Changes ♻️ 🚧
- Kindly work on writing the unit tests for your application, at the moment you have no tests 🤔🙄
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @miguelesco @carloso0114 👋,Your project is complete! There is nothing else to say other than... it's time to merge it Congratulations! 🎉Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
What's new
-Create directories for all Redux state slice files (rockets, missions).
Live Preview
https://miguelesco.github.io/space-travelers/#/
Explaining video
https://drive.google.com/file/d/19v2qmLicQpC1iwcgVnjCYieaM2OXJ-M-/view?usp=sharing