One ore more namespaces failed to connect: ...

[arnoldknott]

Describe the bug
A failed connection in the engine is supposed to return One or more namespaces failed to connect: <namespace names>
However there's a + missing at the end of this line:

python-socketio/src/socketio/async_client.py

Line 178 in 46069e7

'One or more namespaces failed to connect'

So the strings don't get concatenated.

To Reproduce
Steps to reproduce the behavior:
in the connect event, raise ConnectionRefusedError("my dummy error")

Expected behavior
Due to the missing +, an empty string is returned

Logs
The logs don't have an error - as expected.

[miguelgrinberg]

Thanks. I'll review this and correct it so that the error text includes the names.

[arnoldknott]

@miguelgrinberg maybe you could add a test, for example to namespaces:

        ns = MyNamespace('/foo')
        try:
                ns.trigger_event('connect', 'sid', {'foo': 'bar'})
                raise Exception("This should have failed due to un-mocked server")
        except ConnectionError as err:
                assert str(err) == "One or more namespaces failed to connect: /foo"

Inspired by this test.

This is kinda the way it got triggered in my pipeline. 😉