Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating an Odometer Reading #211

Closed
Tracked by #260
mikaelacaron opened this issue Oct 24, 2023 · 2 comments · Fixed by #271
Closed
Tracked by #260

Updating an Odometer Reading #211

mikaelacaron opened this issue Oct 24, 2023 · 2 comments · Fixed by #271
Labels
first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed improvement Improve an existing feature (like error handling)

Comments

@mikaelacaron
Copy link
Owner

Describe the feature you want to improve

  • Add a swipe action to swipe left on a row for an odometer reading on the OdometerView and show an edit view as a sheet
  • The sheet should be called EditOdometerReadingView and put in the correct folder
  • Show a sheet to edit the values for that OdometerReading

See how the code works for editing a MaintenanceEvent on the DashboardView, this view should work in the same way

Describe alternatives you've considered

  • N/A
@mikaelacaron mikaelacaron added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest improvement Improve an existing feature (like error handling) first-timers-only Issues specifically for people who are new to open source labels Oct 24, 2023
@ShaniDan
Copy link

Hi Mikaela.
Can I work on this issue? I did a similar view in my personal project.

@mikaelacaron
Copy link
Owner Author

You got it! See how it's implemented in the DashboardView I'd like this implemented in a similar way

@mikaelacaron mikaelacaron moved this from Todo to In Progress in Basic Car Maintenance Oct 26, 2023
ShaniDan added a commit to ShaniDan/Basic-Car-Maintenance that referenced this issue Oct 27, 2023
@ShaniDan
Issue mikaelacaron#211 - Updating an Odometer Reading - ShaniDan
717f910 
- Added swipeAction and sheet to the OdometerView
- Created a new file EditOdometerReadingView
- Added updateReading function to OdometerViewModel
@ShaniDan ShaniDan mentioned this issue Oct 27, 2023
Closed
ShaniDan added a commit to ShaniDan/Basic-Car-Maintenance that referenced this issue Nov 5, 2023
@ShaniDan
Issue mikaelacaron#211 - Updating an Odometer Reading - ShaniDan
1e76dd8 
- Added swipeAction and sheet to the OdometerView
- Created a new file EditOdometerReadingView
- Added updateReading function to OdometerViewModel
ShaniDan added a commit to ShaniDan/Basic-Car-Maintenance that referenced this issue Nov 7, 2023
@ShaniDan
Issue mikaelacaron#211 - Updating an Odometer Reading - ShaniDan
482fb59 
- Added swipeAction and sheet to the OdometerView
- Created a new file EditOdometerReadingView
- Added updateReading function to OdometerViewModel
@mikaelacaron mikaelacaron mentioned this issue Nov 24, 2023
Open
16 tasks
@mikaelacaron mikaelacaron mentioned this issue Nov 25, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Basic Car Maintenance Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed improvement Improve an existing feature (like error handling)
Projects
Basic Car Maintenance
Status: Done
Milestone
No milestone
2 participants
@mikaelacaron @ShaniDan