Fix DashboardView no events on 1st load

[hanhqvu]

What it Does

• Closes BUG - DashboardView events Aren't Loading on the First Load #210
• This PR will call the closure to get the events & vehicles when the app is in the foreground, not when the view appear

How I Tested

• Build then run the app in the simulator

Notes

• I'm not entirely sure if this is best practice

Screenshot

[mikaelacaron]

@hanhqvu No I would not solve it this way, is this not being called properly in the .task?

Also the code you removed from the makeAddMaintenanceView function will cause a bug, why is this removed?

[hanhqvu]

@mikaelacaron I added breakpoints to .task and it is not called when DashboardView appear on 1st load. If switch tabs then it got called. Regarding the removed code, I think the bug is tied to .task not being called so not getting vehicles.

[mikaelacaron]

Regarding the removed code, I think the bug is tied to .task not being called so not getting vehicles.

No the point of line 149 to 151

is to recall the events again after an event has been added, to update the list

I added breakpoints to .task and it is not called when DashboardView appear on 1st load.

I totally thought it should be, could you find documentation behind this why it's not called when the view first appears?

[hanhqvu]

Regarding the removed code, I think the bug is tied to .task not being called so not getting vehicles.

No the point of line 149 to 151

is to recall the events again after an event has been added, to update the list

I added breakpoints to .task and it is not called when DashboardView appear on 1st load.

I totally thought it should be, could you find documentation behind this why it's not called when the view first appears?

Ah, I see. My bad on that, I'll revert that.

Also another point, could be because I'm not familiar with Firebase but why does the events get cleared out of memory when the app goes into background. The events should still be in memory if the app is still in memory right?

[mikaelacaron]

could be because I'm not familiar with Firebase but why does the events get cleared out of memory when the app goes into background

This.... I'm not sure.... what scenario did you notice this behavior?

[hanhqvu]

Prior to the my changes after events have been fetched, when I go to the home screen then re-open the app, the events are no longer there.