Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the orientation filter, add tests #20

Merged
merged 4 commits into from
Jun 17, 2021
Merged

improve the orientation filter, add tests #20

merged 4 commits into from
Jun 17, 2021

Commits on Jun 16, 2021

  1. split orientation filter out for ease of testing

    @mikeferguson
    mikeferguson committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    a0dfa0a View commit details
    Browse the repository at this point in the history

  2. split out add_orientations as well

    @mikeferguson
    mikeferguson committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    40571b2 View commit details
    Browse the repository at this point in the history

  3. add tests, including one that fails like we've seen

    @mikeferguson
    mikeferguson committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    050d244 View commit details
    Browse the repository at this point in the history

  4. revamp orientation filter to be more awesome

    @mikeferguson
    mikeferguson committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    2dfd176 View commit details
    Browse the repository at this point in the history