Skip to content

Conversation

hanshuebner
Copy link

These changes are required to build on macOS 15.3 for me.

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont mind bumping the dependency versions, but all of the other changes should be removed

highlighter: new SqlHighlighter(),
...options,
});
}) as Options;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has no effect

"author": "Martin Adamek",
"license": "MIT",
"homepage": "https://mikro-orm.io/docs/guide",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the blank lines, same for the one on line 30

Comment on lines +15 to +16
"@mikro-orm/reflection": "^6.4.6",
"@mikro-orm/seeder": "^6.4.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, those should stay dev deps

@hanshuebner
Copy link
Author

The initial problem was a python build failure of one of the dependencies which I could fix using brew install python-setuptools. I'm not keen on bumping the dependencies without an actual need, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants