Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with lebab #453

Closed
graingert opened this issue Jul 3, 2016 · 2 comments
Closed

merge with lebab #453

graingert opened this issue Jul 3, 2016 · 2 comments

Comments

@graingert
Copy link

Lebab is another tool that does JS autofixing, but focussed on fixers like let and const

https://github.com/mohebifar/lebab

@millermedeiros
Copy link
Owner

millermedeiros commented Jul 6, 2016

there is no way to implement the features we have on esformatter on top of lebab.. they use https://github.com/benjamn/recast internally - which have it's own printer/formatter...

the thing about the "printer" approach is that it receives an AST as input and it decides how to convert that AST into code... so if we "reprint" the whole program, it will be a "destructive" operation (it will remove optional tokens like "()" and all whitespaces/linebreaks)

recast/lebab could reuse esformatter tho... (the same way as jsfmt does)

@graingert
Copy link
Author

Looks like everyone needs to use cst
On 6 Jul 2016 03:40, "Miller Medeiros" notifications@github.com wrote:

Closed #453 #453.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#453 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAZQTMr6CHAGRmPyrbHfv4S5R0v-vo7sks5qSxWkgaJpZM4JD85T
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants