Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with nodejs 14.x #67

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fix compatibility with nodejs 14.x #67

merged 1 commit into from
Mar 17, 2021

Conversation

jamesla
Copy link
Contributor

@jamesla jamesla commented Mar 6, 2021

The runtime and memory_size variables are strings and numbers so the lookup function fails since it requires a map.

The error is:

Error: expected runtime to be one of [nodejs nodejs4.3 nodejs6.10 nodejs8.10 nodejs10.x nodejs12.x java8 java8.al2 java11 python2.7 python3.6 python3.7 python3.8 dotnetcore1.0 dotnetcore2.0 dotnetcore2.1 dotnetcore3.1 nodejs4.3-edge go1.x ruby2.5 ruby2.7 provided provided.al2], got nodejs14.x

@ofhouse
Copy link
Member

ofhouse commented Mar 8, 2021

Can you give more some more context or how to reproduce the error?

The lookup itself seems fine since it got a value for runtime which is nodejs14.x.
The error here may come from an outdated AWS provider, I think support for nodejs14.x requires at least v3.27.0, see hashicorp/terraform-provider-aws#17450

@jamesla jamesla changed the title Incorrect types on lambda function modules Fix compatibility with nodejs 14.x Mar 8, 2021
@jamesla
Copy link
Contributor Author

jamesla commented Mar 8, 2021

Can you give more some more context or how to reproduce the error?

The lookup itself seems fine since it got a value for runtime which is nodejs14.x.
The error here may come from an outdated AWS provider, I think support for nodejs14.x requires at least v3.27.0, see hashicorp/terraform-provider-aws#17450

Ah yes you are correct have fixed the PR.

@ofhouse ofhouse merged commit 9abf894 into milliHQ:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants