Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Enable GroupBy with group size function #33544

Open
1 task done
MrPresent-Han opened this issue Jun 3, 2024 · 1 comment
Open
1 task done

[Feature]: Enable GroupBy with group size function #33544

MrPresent-Han opened this issue Jun 3, 2024 · 1 comment
Assignees
@xiaofan-luan @MrPresent-Han
Labels
kind/feature Issues related to feature request from users

Comments

@MrPresent-Han
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Currently, group_by operator only support 1 entities per group which is very limited.
This issue is to enhance the functionality of group by operator

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response
@MrPresent-Han MrPresent-Han added the kind/feature Issues related to feature request from users label Jun 3, 2024
@MrPresent-Han
Copy link
Contributor Author

/assign

MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 7, 2024
@MrPresent-Han
feat: support group_size for search_group_by(milvus-io#33544)
9c70bdd 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 7, 2024
@MrPresent-Han
feat: support group_size for search_group_by(milvus-io#33544)
c900fae 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
@MrPresent-Han MrPresent-Han mentioned this issue Jun 7, 2024
Merged
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 11, 2024
feat: support group_size for search_group_by(milvus-io#33544)
d9f4c2b 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 11, 2024
feat: support group_size for search_group_by(milvus-io#33544)
350d028 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 11, 2024
feat: support group_size for search_group_by(milvus-io#33544)
c59c0a8 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support group_size for search_group_by(milvus-io#33544)
47944da 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support group_size for search_group_by(milvus-io#33544)
1d37aca 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support groupby size on go-layer(milvus-io#33544)
626104d 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support groupby size on go-layer(milvus-io#33544)
f4c184e 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@MrPresent-Han MrPresent-Han mentioned this issue Jun 13, 2024
Merged
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support groupby size on go-layer(milvus-io#33544)
16274d3 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support groupby size on go-layer(milvus-io#33544)
30acf5e 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jun 13, 2024
feat: support groupby size on go-layer(milvus-io#33544)
70712eb 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 3, 2024
feat: support group_size for search_group_by(milvus-io#33544)
9f2405e 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 4, 2024
@MrPresent-Han
feat: support group_size for search_group_by(milvus-io#33544)
d22c47e 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Jul 12, 2024
@MrPresent-Han
feat: support group_size for search_group_by(#33544) (#33720)
f00c529 
related: #33544

mainly changes in three aspects:

1. enable setting group_size for group by function
2. separate normal reduce and group by reduce
3. eleminate uncessary padding in search result for reducing

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
chyezh pushed a commit to chyezh/milvus that referenced this issue Jul 15, 2024
@MrPresent-Han @chyezh
feat: support group_size for search_group_by(milvus-io#33544) (milvus…
d6fb061 
…-io#33720)

related: milvus-io#33544

mainly changes in three aspects:

1. enable setting group_size for group by function
2. separate normal reduce and group by reduce
3. eleminate uncessary padding in search result for reducing

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Aug 26, 2024
feat: support groupby size on go-layer(milvus-io#33544)
3f117db 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Aug 26, 2024
feat: support groupby size on go-layer(milvus-io#33544)
8e526cd 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Aug 27, 2024
feat: support groupby size on go-layer(milvus-io#33544)
17c4adb 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Aug 27, 2024
@MrPresent-Han
feat: support groupby size on go-layer(#33544) (#33845)
bfd9d86 
related: #33544

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
@MrPresent-Han MrPresent-Han mentioned this issue Aug 29, 2024
Merged
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Aug 29, 2024
enhance: make search groupby stop when reaching topk groups(milvus-io…
40e5ac8 
…#33544)

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Aug 30, 2024
enhance: make search groupby stop when reaching topk groups(milvus-io…
8fd2fb5 
…#33544)

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Sep 1, 2024
enhance: make search groupby stop when reaching topk groups(milvus-io…
62e91c3 
…#33544)

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Sep 2, 2024
@MrPresent-Han
enhance: make search groupby stop when reaching topk groups (#35814)
4641fd9 
related: #33544

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Sep 12, 2024
enhance: restrict max group size(milvus-io#33544)
b18b7b5 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@MrPresent-Han MrPresent-Han mentioned this issue Sep 12, 2024
Merged
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Sep 13, 2024
enhance: restrict max group size(milvus-io#33544)
ac66e6e 
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Sep 14, 2024
@MrPresent-Han
enhance: restrict max group size(#33544) (#36223)
b8b4aea 
related: #33544

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaofan-luan xiaofan-luan

@MrPresent-Han MrPresent-Han

Labels
kind/feature Issues related to feature request from users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaofan-luan @MrPresent-Han