Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and tests for Mac M1, also enabled more tests for OSX systems #16552

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

soothing-rain
Copy link
Contributor

issue: #16500

/kind enhancement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

@sre-ci-robot sre-ci-robot added kind/enhancement Issues or changes related to enhancement area/compilation labels Apr 20, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 20, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Apr 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

@soothing-rain E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #16552 (4786bf8) into master (65e01bc) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16552      +/-   ##
==========================================
+ Coverage   80.56%   80.65%   +0.08%     
==========================================
  Files         437      437              
  Lines       68402    68402              
==========================================
+ Hits        55111    55172      +61     
+ Misses      10658    10606      -52     
+ Partials     2633     2624       -9     
Impacted Files Coverage Δ
internal/indexcoord/meta_table.go 83.16% <0.00%> (-0.26%) ⬇️
internal/rootcoord/meta_table.go 80.86% <0.00%> (+0.18%) ⬆️
internal/rootcoord/root_coord.go 77.90% <0.00%> (+0.32%) ⬆️
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 81.64% <0.00%> (+0.37%) ⬆️
internal/distributed/rootcoord/service.go 80.85% <0.00%> (+0.78%) ⬆️
internal/querycoord/query_coord.go 73.72% <0.00%> (+0.78%) ⬆️
internal/rootcoord/import_manager.go 88.45% <0.00%> (+0.78%) ⬆️
internal/distributed/rootcoord/client/client.go 96.19% <0.00%> (+1.01%) ⬆️
internal/querycoord/global_meta_broker.go 71.65% <0.00%> (+1.06%) ⬆️
internal/indexnode/indexnode_mock.go 84.84% <0.00%> (+1.13%) ⬆️
... and 5 more

@mergify mergify bot added the ci-passed label Apr 20, 2022
issue: milvus-io#16500

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f93862f into milvus-io:master Apr 20, 2022
@soothing-rain soothing-rain deleted the fixm1 branch April 21, 2022 07:04
soothing-rain added a commit to soothing-rain/milvus that referenced this pull request Apr 24, 2022
…ms (milvus-io#16552)

issue: milvus-io#16500

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
soothing-rain added a commit to soothing-rain/milvus that referenced this pull request May 12, 2022
…ms (milvus-io#16552)

issue: milvus-io#16500

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants