Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support etcd authentication #28912

Closed

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 1, 2023

issue: #28895
add 3 configuration for ETCD config

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PowderLi
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Dec 1, 2023
Copy link
Contributor

mergify bot commented Dec 1, 2023

@PowderLi

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@PowderLi PowderLi changed the title feature: support etcd authentication feat: support etcd authentication Dec 1, 2023
@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/invalid-pr-format labels Dec 1, 2023
Copy link
Contributor

mergify bot commented Dec 1, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 1, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5be9099) 80.36% compared to head (e0b0d2a) 82.01%.

❗ Current head e0b0d2a differs from pull request most recent head 668b7da. Consider uploading reports for the commit 668b7da to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #28912      +/-   ##
==========================================
+ Coverage   80.36%   82.01%   +1.65%     
==========================================
  Files         931      862      -69     
  Lines      128508   122076    -6432     
==========================================
- Hits       103272   100123    -3149     
+ Misses      21842    18630    -3212     
+ Partials     3394     3323      -71     
Files Coverage Δ
internal/distributed/datacoord/service.go 88.06% <100.00%> (+0.36%) ⬆️
internal/distributed/datanode/service.go 78.60% <100.00%> (+0.38%) ⬆️
internal/distributed/indexnode/service.go 71.34% <100.00%> (+0.53%) ⬆️
internal/distributed/proxy/service.go 82.44% <100.00%> (+0.17%) ⬆️
internal/distributed/querycoord/service.go 74.67% <100.00%> (+0.33%) ⬆️
internal/distributed/querynode/service.go 80.48% <100.00%> (+0.28%) ⬆️
internal/distributed/rootcoord/service.go 80.86% <100.00%> (+1.30%) ⬆️
internal/kv/etcd/metakv_factory.go 70.73% <100.00%> (+2.31%) ⬆️
internal/util/dependency/kv/kv_client_handler.go 89.18% <100.00%> (+0.95%) ⬆️
pkg/config/etcd_source.go 73.19% <100.00%> (+0.85%) ⬆️
... and 6 more

... and 330 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 4, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 6, 2023

rerun ut

1 similar comment
@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 7, 2023

rerun ut

@PowderLi
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 12, 2023
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 6, 2024
@mergify mergify bot removed the ci-passed label Jan 6, 2024
Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Jan 6, 2024
Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

add 3 configuration for ETCD config

Signed-off-by: PowderLi <min.li@zilliz.com>
@PowderLi
Copy link
Contributor Author

PowderLi commented Jan 7, 2024

rerun ut

@PowderLi PowderLi closed this Jan 23, 2024
@PowderLi PowderLi deleted the master-etcd-authentication branch January 23, 2024 12:20
@PowderLi
Copy link
Contributor Author

/reopen

@sre-ci-robot
Copy link
Contributor

@PowderLi: Failed to re-open PR: state cannot be changed. The master-etcd-authentication branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PowderLi
Copy link
Contributor Author

/reopen

@sre-ci-robot
Copy link
Contributor

@PowderLi: Failed to re-open PR: state cannot be changed. The master-etcd-authentication branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Apr 24, 2024
Copy link
Contributor

mergify bot commented Apr 24, 2024

@PowderLi Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test kind/feature Issues related to feature request from users needs-dco DCO is missing in this pull request. sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants