-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support etcd authentication #28912
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PowderLi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@PowderLi ut workflow job failed, comment |
d515f36
to
f9eb3be
Compare
@PowderLi ut workflow job failed, comment |
f9eb3be
to
597cd07
Compare
@PowderLi ut workflow job failed, comment |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #28912 +/- ##
==========================================
+ Coverage 80.36% 82.01% +1.65%
==========================================
Files 931 862 -69
Lines 128508 122076 -6432
==========================================
- Hits 103272 100123 -3149
+ Misses 21842 18630 -3212
+ Partials 3394 3323 -71
|
597cd07
to
19da146
Compare
@PowderLi E2e jenkins job failed, comment |
19da146
to
e2d5f14
Compare
rerun ut |
1 similar comment
rerun ut |
e2d5f14
to
e0b0d2a
Compare
rerun ut |
e0b0d2a
to
8ee956f
Compare
@PowderLi ut workflow job failed, comment |
8ee956f
to
27ce2e1
Compare
@PowderLi E2e jenkins job failed, comment |
@PowderLi ut workflow job failed, comment |
add 3 configuration for ETCD config Signed-off-by: PowderLi <min.li@zilliz.com>
27ce2e1
to
668b7da
Compare
rerun ut |
/reopen |
@PowderLi: Failed to re-open PR: state cannot be changed. The master-etcd-authentication branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@PowderLi: Failed to re-open PR: state cannot be changed. The master-etcd-authentication branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@PowderLi Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
issue: #28895
add 3 configuration for ETCD config