Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick]Skip updating checkpoint after dropcollection #29221

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

XuanYang-cn
Copy link
Contributor

pr: #29220

pr: milvus-io#29220

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 14, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 14, 2023
Copy link
Contributor

mergify bot commented Dec 14, 2023

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

4 similar comments
@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #29221 (23848d5) into 2.3 (c2ce7bc) will increase coverage by 0.02%.
Report is 16 commits behind head on 2.3.
The diff coverage is 88.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29221      +/-   ##
==========================================
+ Coverage   82.03%   82.06%   +0.02%     
==========================================
  Files         832      831       -1     
  Lines      119113   119086      -27     
==========================================
+ Hits        97718    97726       +8     
+ Misses      18168    18131      -37     
- Partials     3227     3229       +2     
Files Coverage Δ
internal/datanode/flow_graph_time_tick_node.go 90.27% <100.00%> (+1.21%) ⬆️
internal/datanode/flow_graph_dd_node.go 92.38% <0.00%> (ø)

... and 37 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 15, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7b05997 into milvus-io:2.3 Dec 15, 2023
14 checks passed
@XuanYang-cn XuanYang-cn deleted the cherry-skip branch December 15, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants