Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] exclude insertData before growing checkpoint #29559

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #29558
See also: #29556
Refine exclude segment function signature
Add exclude growing before checkpoint logic

Resolves: milvus-io#29556
Refine exclude segment function signature
Add exclude growing before checkpoint logic

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 28, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (687eb39) 82.15% compared to head (95ab0d7) 82.14%.
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29559      +/-   ##
==========================================
- Coverage   82.15%   82.14%   -0.02%     
==========================================
  Files         824      833       +9     
  Lines      119676   119711      +35     
==========================================
+ Hits        98323    98334      +11     
- Misses      18128    18154      +26     
+ Partials     3225     3223       -2     
Files Coverage Δ
internal/querynodev2/pipeline/filter_node.go 82.22% <ø> (ø)
internal/querynodev2/pipeline/filter_policy.go 100.00% <100.00%> (ø)
internal/querynodev2/pipeline/pipeline.go 100.00% <100.00%> (ø)
internal/querynodev2/services.go 88.63% <77.77%> (-0.46%) ⬇️

... and 163 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 28, 2023
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 67313cc into milvus-io:2.3 Dec 28, 2023
14 checks passed
@congqixia congqixia deleted the cp_29558 branch December 29, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants