enhance: pre-allocate result FieldData space to reduce copy & growslice #29726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: milvus-io#29113 Add a new utitliy function in `pkg/util/typetuil` to pre-allocate field data slice capacity acoording to search limit. This shall avoid copying the data during `AppendFieldData` when previous slice is out of space. And shall also save CPU time during high paylog. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
mergify
bot
added
dco-passed
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29726 +/- ##
==========================================
+ Coverage 80.82% 83.23% +2.41%
==========================================
Files 926 693 -233
Lines 127767 110943 -16824
==========================================
- Hits 103271 92348 -10923
+ Misses 21145 15123 -6022
- Partials 3351 3472 +121
|
yanliang567
added
ci-passed
manual-pass
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 11, 2024
…ce (milvus-io#29726) See also: milvus-io#29113 Add a new utitliy function in `pkg/util/typetuil` to pre-allocate field data slice capacity acoording to search limit. This shall avoid copying the data during `AppendFieldData` when previous slice is out of space. And shall also save CPU time during high paylog. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…growslice (#29726) (#29866) Cherry-pick from master pr: #29726 See also: #29113 Add a new utitliy function in `pkg/util/typetuil` to pre-allocate field data slice capacity acoording to search limit. This shall avoid copying the data during `AppendFieldData` when previous slice is out of space. And shall also save CPU time during high paylog. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #29113
Add a new utitliy function in
pkg/util/typetuilto pre-allocate field data slice capacity acoording to search limit. This shall avoid copying the data duringAppendFieldDatawhen previous slice is out of space. And shall also save CPU time during high paylog.