Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compact operation on datacoord meta should preform as a transcation #29776

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: compact operation on datacoord meta should preform as a transcation #29776

merged 1 commit into from
Jan 12, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 8, 2024

issue: #29691
pr: #29775

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 8, 2024
@chyezh chyezh force-pushed the fixup_no_such_key_when_loading_2_3 branch 2 times, most recently from 2033591 to faa5164 Compare January 8, 2024 16:17
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8c2ca3f) 82.11% compared to head (fd42a09) 82.16%.
Report is 18 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29776      +/-   ##
==========================================
+ Coverage   82.11%   82.16%   +0.04%     
==========================================
  Files         832      833       +1     
  Lines      119823   120040     +217     
==========================================
+ Hits        98397    98625     +228     
+ Misses      18205    18199       -6     
+ Partials     3221     3216       -5
Files Coverage Δ
internal/datacoord/compaction.go 95.69% <100.00%> (+0.85%) ⬆️
internal/datacoord/meta.go 89.07% <73.33%> (-0.18%) ⬇️

... and 42 files with indirect coverage changes

@chyezh chyezh force-pushed the fixup_no_such_key_when_loading_2_3 branch from faa5164 to 967b5b6 Compare January 9, 2024 02:22
@chyezh
Copy link
Contributor Author

chyezh commented Jan 9, 2024

rerun ut

2 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Jan 9, 2024

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jan 9, 2024

rerun ut

@chyezh chyezh force-pushed the fixup_no_such_key_when_loading_2_3 branch from 967b5b6 to fd42a09 Compare January 12, 2024 02:30
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 12, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 12, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Jan 12, 2024

/lgtm

@chyezh
Copy link
Contributor Author

chyezh commented Jan 12, 2024

Previous implementation has revert logic between prepare and alter.
So, merge two step together is OK.

@czs007
Copy link
Collaborator

czs007 commented Jan 12, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 12, 2024
@sre-ci-robot sre-ci-robot merged commit 98aae10 into milvus-io:2.3 Jan 12, 2024
13 of 14 checks passed
@chyezh chyezh deleted the fixup_no_such_key_when_loading_2_3 branch January 15, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@XuanYang-cn XuanYang-cn

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chyezh @czs007 @sre-ci-robot @XuanYang-cn