Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dynamic update rate limit config with wrong value #29902

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

weiliu1031
Copy link
Contributor

pr: #29901
when apply dynamic config changes, we should format the value to proper unit
This PR fix update rate limit config with wrong value.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0b711e) 82.13% compared to head (c47e547) 82.14%.
Report is 8 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #29902   +/-   ##
=======================================
  Coverage   82.13%   82.14%           
=======================================
  Files         833      833           
  Lines      120080   120080           
=======================================
+ Hits        98632    98635    +3     
- Misses      18222    18224    +2     
+ Partials     3226     3221    -5     
Files Coverage Δ
internal/proxy/multi_rate_limiter.go 90.59% <100.00%> (-1.29%) ⬇️

... and 12 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 11, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 16e7f51 into milvus-io:2.3 Jan 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants