Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase expr recursion depth to avoid parse failed (#29860) #30021

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: increase expr recursion depth to avoid parse failed (#29860) #30021

merged 1 commit into from
Jan 16, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jan 16, 2024

pr: #29860

@zhagnlu
fix: increase expr recursion depth to avoid parse failed (milvus-io#2…
cfcef30 
…9860)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>

fix: Add multi logical exprs case (milvus-io#29871)

milvus-io#29759

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ff93e8b) 82.22% compared to head (cfcef30) 82.21%.
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30021      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.01%     
==========================================
  Files         834      825       -9     
  Lines      120368   120324      -44     
==========================================
- Hits        98972    98927      -45     
  Misses      18175    18175              
- Partials     3221     3222       +1
Files Coverage Δ
internal/core/src/query/Plan.cpp 57.14% <0.00%> (-7.01%) ⬇️

... and 162 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2024

/approve

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaofan-luan, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan xiaofan-luan merged commit 9f6a19c into milvus-io:2.3 Jan 16, 2024
12 of 14 checks passed
@czs007 czs007 mentioned this pull request Jan 17, 2024
Merged
@yanliang567 yanliang567 mentioned this pull request Jul 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved area/test dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhagnlu @czs007 @xiaofan-luan @sre-ci-robot