Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [cherry-pick] replace magic number with ParamItem for dist handler (#30020) #30070

Merged
merged 1 commit into from
Jan 18, 2024
Merged

enhance: [cherry-pick] replace magic number with ParamItem for dist handler (#30020) #30070

merged 1 commit into from
Jan 18, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #30020
See also #28817

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 17, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f6a19c) 82.18% compared to head (c2d3641) 82.21%.
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30070      +/-   ##
==========================================
+ Coverage   82.18%   82.21%   +0.02%     
==========================================
  Files         825      834       +9     
  Lines      120336   120404      +68     
==========================================
+ Hits        98901    98986      +85     
+ Misses      18207    18194      -13     
+ Partials     3228     3224       -4
Files Coverage Δ
internal/distributed/proxy/httpserver/utils.go 85.61% <100.00%> (+0.82%) ⬆️
internal/querycoordv2/dist/dist_handler.go 98.32% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.31% <100.00%> (+0.01%) ⬆️

... and 163 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

3 similar comments
@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 18, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 18, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 7f32576 into milvus-io:2.3 Jan 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@weiliu1031 weiliu1031 Awaiting requested review from weiliu1031

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @weiliu1031