Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the system rejects all queries and never recovers if enabled read rate limit (#30061) #30196

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 22, 2024

fix #30060
pr: #30061

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (565d37c) 82.24% compared to head (cbfb3ca) 82.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30196      +/-   ##
==========================================
- Coverage   82.24%   82.23%   -0.02%     
==========================================
  Files         837      837              
  Lines      120818   120811       -7     
==========================================
- Hits        99370    99350      -20     
- Misses      18201    18212      +11     
- Partials     3247     3249       +2     
Files Coverage Δ
internal/querynodev2/collector/counter.go 100.00% <100.00%> (ø)
...nal/querynodev2/tasks/concurrent_safe_scheduler.go 88.42% <100.00%> (ø)

... and 10 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 22, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9bd94c4 into milvus-io:2.3 Jan 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants