Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Allows proactive warming up of chunk cache (#30182) #30289

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

bigsheeper
Copy link
Contributor

Allows proactive warming up of chunk cache. Original vector data will be asynchronously loaded into the chunk cache during the load process. It has the potential to significantly reduce query/search latency for a certain duration after the load, albeit with a concurrent increase in disk usage.

issue: #30181

pr: #30182

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 25, 2024
Copy link
Contributor

mergify bot commented Jan 25, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Jan 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 25, 2024
Copy link
Contributor

mergify bot commented Jan 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@bigsheeper
Copy link
Contributor Author

rerun ut

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 25, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (d182a51) 82.09% compared to head (0e40634) 82.08%.
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30289      +/-   ##
==========================================
- Coverage   82.09%   82.08%   -0.02%     
==========================================
  Files         840      830      -10     
  Lines      121034   121046      +12     
==========================================
- Hits        99368    99363       -5     
- Misses      18422    18441      +19     
+ Partials     3244     3242       -2     
Files Coverage Δ
internal/core/src/segcore/SegmentSealed.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 89.47% <ø> (+0.58%) ⬆️
internal/core/src/storage/ChunkCache.h 100.00% <ø> (ø)
pkg/util/paramtable/component_param.go 98.33% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/segments/segment_loader.go 76.23% <0.00%> (ø)
internal/core/src/storage/ChunkCache.cpp 78.72% <70.58%> (+1.45%) ⬆️
internal/core/src/segcore/segment_c.cpp 65.82% <0.00%> (-2.98%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 78.58% <0.00%> (-2.08%) ⬇️
internal/querynodev2/segments/segment.go 73.89% <7.69%> (-4.73%) ⬇️

... and 160 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jan 26, 2024

/lgtm

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 26, 2024
@sre-ci-robot sre-ci-robot merged commit e0f987e into milvus-io:2.3 Jan 26, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants