Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [cherry-pick] restful phase two #30430

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Feb 1, 2024

issue: #28348 #29732 #29533

Support to trace the grpc request, pr: #28349
Support to trace restful request and request error, pr: #28685

restful phase two, pr: #29728 #30343
include: collections, entities, partitions, users, roles, indexes, aliases, import jobs

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 1, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Feb 1, 2024
Copy link
Contributor

mergify bot commented Feb 1, 2024

@PowderLi Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/feature Issues related to feature request from users and removed do-not-merge/missing-related-pr labels Feb 1, 2024
@czs007
Copy link
Collaborator

czs007 commented Feb 1, 2024

/hold

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 90.22765% with 176 lines in your changes are missing coverage. Please review.

Project coverage is 82.32%. Comparing base (ef530a2) to head (d465561).
Report is 14 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30430      +/-   ##
==========================================
+ Coverage   82.23%   82.32%   +0.09%     
==========================================
  Files         844      848       +4     
  Lines      122286   124066    +1780     
==========================================
+ Hits       100557   102137    +1580     
- Misses      18492    18650     +158     
- Partials     3237     3279      +42     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v1.go 91.42% <100.00%> (-0.03%) ⬇️
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)
internal/proxy/trace_log_interceptor.go 100.00% <100.00%> (ø)
internal/proxy/util.go 90.75% <100.00%> (-0.02%) ⬇️
pkg/util/contextutil/context_util.go 63.63% <100.00%> (+43.63%) ⬆️
pkg/util/paramtable/component_param.go 98.34% <100.00%> (+<0.01%) ⬆️
pkg/util/requestutil/getter.go 100.00% <100.00%> (ø)
internal/distributed/proxy/service.go 80.58% <85.71%> (+0.09%) ⬆️
internal/distributed/proxy/httpserver/utils.go 84.22% <82.27%> (-0.30%) ⬇️
...distributed/proxy/httpserver/timeout_middleware.go 79.09% <79.09%> (ø)
... and 1 more

... and 18 files with indirect coverage changes

SimFG and others added 4 commits March 15, 2024 19:57
Signed-off-by: SimFG <bang.fu@zilliz.com>
issue: milvus-io#29732

Signed-off-by: PowderLi <min.li@zilliz.com>
@czs007 czs007 added this to the 2.3.13 milestone Mar 25, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Mar 25, 2024

/unhold

@sre-ci-robot sre-ci-robot merged commit f2f0d44 into milvus-io:2.3 Mar 25, 2024
14 checks passed
@PowderLi PowderLi deleted the 2.3-restful-phase-two branch April 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants