Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Update Knowhere version #30513

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Feb 4, 2024

/kind improvement

Signed-off-by: xianliang <xianliang.li@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/compilation size/XS Denotes a PR that changes 0-9 lines. labels Feb 4, 2024
Copy link
Contributor

mergify bot commented Feb 4, 2024

@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Feb 4, 2024

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@foxspy foxspy changed the title Update Knowhere version enhance: Update Knowhere version Feb 4, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Feb 4, 2024
@foxspy
Copy link
Contributor Author

foxspy commented Feb 4, 2024

/kind branch-feature

@czs007
Copy link
Collaborator

czs007 commented Feb 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc2bc3f) 82.14% compared to head (a65efa5) 82.15%.
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30513      +/-   ##
==========================================
+ Coverage   82.14%   82.15%   +0.01%     
==========================================
  Files         841      841              
  Lines      121338   121338              
==========================================
+ Hits        99673    99686      +13     
+ Misses      18428    18423       -5     
+ Partials     3237     3229       -8     

see 19 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 4, 2024
@sre-ci-robot sre-ci-robot merged commit 88d57f1 into milvus-io:2.3 Feb 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants