Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pick]enhance: Use virtual host for tencent cloud #30685

Merged

Conversation

xiaocai2333
Copy link
Contributor

master pr: #30650

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 20, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Feb 20, 2024
Copy link
Contributor

mergify bot commented Feb 20, 2024

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (48707f3) 82.11% compared to head (4e0c0c6) 82.14%.
Report is 11 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30685      +/-   ##
==========================================
+ Coverage   82.11%   82.14%   +0.02%     
==========================================
  Files         841      841              
  Lines      121362   121376      +14     
==========================================
+ Hits        99658    99704      +46     
+ Misses      18455    18431      -24     
+ Partials     3249     3241       -8     
Files Coverage Δ
internal/storage/minio_object_storage.go 76.31% <0.00%> (-0.51%) ⬇️

... and 18 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Feb 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Feb 21, 2024
@sre-ci-robot sre-ci-robot merged commit e8e221c into milvus-io:2.3 Feb 21, 2024
13 of 14 checks passed
@xiaocai2333 xiaocai2333 deleted the use_vritual_host_for_tencent-2.3 branch February 27, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants