Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Update disk usage metrics after segment released (#30702) #30707

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #30702
See also #30701

See also milvus-io#30701

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Feb 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4c4bf9) 82.17% compared to head (50b0a84) 82.12%.
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30707      +/-   ##
==========================================
- Coverage   82.17%   82.12%   -0.05%     
==========================================
  Files         831      841      +10     
  Lines      121297   121389      +92     
==========================================
+ Hits        99671    99693      +22     
- Misses      18390    18453      +63     
- Partials     3236     3243       +7     
Files Coverage Δ
internal/querynodev2/segments/segment.go 74.05% <100.00%> (+0.16%) ⬆️

... and 167 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 20, 2024
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 31f33f6 into milvus-io:2.3 Feb 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants