-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nil ptr is used as nil interface in grpc client #30755
fix: nil ptr is used as nil interface in grpc client #30755
Conversation
/lgtm |
@chyezh ut workflow job failed, comment |
Signed-off-by: chyezh <chyezh@outlook.com>
5fece1e
to
4e27b5f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #30755 +/- ##
==========================================
+ Coverage 82.11% 82.16% +0.05%
==========================================
Files 841 841
Lines 121390 121400 +10
==========================================
+ Hits 99677 99746 +69
+ Misses 18468 18420 -48
+ Partials 3245 3234 -11
|
/lgtm |
issue: #30715
pr: #30754
Panic with segment violation when calling method on this nil struct pointer.