Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil ptr is used as nil interface in grpc client #30755

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 22, 2024

issue: #30715
pr: #30754

  • Bug: Set nil struct pointer to describe nil interface.
    Panic with segment violation when calling method on this nil struct pointer.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 22, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

Copy link
Contributor

mergify bot commented Feb 22, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fixup_nil_ptr_as_nil_interface_grpc_client_2_3 branch from 5fece1e to 4e27b5f Compare February 22, 2024 08:55
@sre-ci-robot sre-ci-robot removed the lgtm label Feb 22, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (31f33f6) to head (4e27b5f).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30755      +/-   ##
==========================================
+ Coverage   82.11%   82.16%   +0.05%     
==========================================
  Files         841      841              
  Lines      121390   121400      +10     
==========================================
+ Hits        99677    99746      +69     
+ Misses      18468    18420      -48     
+ Partials     3245     3234      -11     
Files Coverage Δ
internal/distributed/datacoord/client/client.go 96.09% <100.00%> (ø)
internal/distributed/datanode/client/client.go 90.90% <100.00%> (ø)
internal/distributed/indexnode/client/client.go 76.82% <100.00%> (ø)
internal/distributed/proxy/client/client.go 95.61% <100.00%> (ø)
internal/distributed/querycoord/client/client.go 93.38% <100.00%> (ø)
internal/distributed/querynode/client/client.go 88.29% <100.00%> (ø)
internal/distributed/rootcoord/client/client.go 94.29% <100.00%> (ø)

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 22, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit a9625ec into milvus-io:2.3 Feb 23, 2024
14 checks passed
@chyezh chyezh deleted the fixup_nil_ptr_as_nil_interface_grpc_client_2_3 branch February 23, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants