Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: reduce 1x memory copy when loading json (#30753) #30864

Merged
merged 1 commit into from
Feb 28, 2024
Merged

enhance: reduce 1x memory copy when loading json (#30753) #30864

merged 1 commit into from
Feb 28, 2024

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented Feb 27, 2024 •
edited
Loading

/kind improvement
pr: #30753

@longjiquan
enhance: reduce 1x memory copy when loading json (milvus-io#30753)
05f8def 
/kind improvement

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Feb 27, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Feb 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024

@longjiquan Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Feb 27, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (2896f5e) to head (05f8def).
Report is 5 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30864      +/-   ##
==========================================
+ Coverage   82.11%   82.18%   +0.06%     
==========================================
  Files         841      831      -10     
  Lines      122006   121322     -684     
==========================================
- Hits       100190    99711     -479     
+ Misses      18588    18378     -210     
- Partials     3228     3233       +5
Files Coverage Δ
internal/core/src/storage/FieldDataInterface.h 65.81% <0.00%> (-2.33%) ⬇️

... and 135 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Feb 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Feb 28, 2024
@sre-ci-robot sre-ci-robot merged commit b10bec3 into milvus-io:2.3 Feb 28, 2024
13 of 14 checks passed
@longjiquan longjiquan deleted the cp-30753 branch February 28, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longjiquan @czs007 @sre-ci-robot