Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: optimize the memory usage and speed up loading variable length data (#30787) #30900

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

longjiquan
Copy link
Contributor

pr: #30787
/kind improvement

…th data (milvus-io#30787)

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 28, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 28, 2024
Copy link
Contributor

mergify bot commented Feb 28, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 28, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (df16bf6) to head (981771f).
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30900      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.02%     
==========================================
  Files         841      831      -10     
  Lines      121457   121377      -80     
==========================================
- Hits        99826    99788      -38     
+ Misses      18402    18358      -44     
- Partials     3229     3231       +2     
Files Coverage Δ
internal/core/src/common/Json.h 86.27% <100.00%> (+0.85%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 78.12% <100.00%> (-0.39%) ⬇️
internal/core/src/mmap/Column.h 95.26% <84.61%> (-3.44%) ⬇️

... and 162 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 28, 2024
@czs007
Copy link
Collaborator

czs007 commented Feb 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b0d8e21 into milvus-io:2.3 Feb 29, 2024
14 checks passed
@longjiquan longjiquan deleted the cp-30787 branch February 29, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants