Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support varchar autoid for bulkinsertV1 (#30896) #30913

Merged

Conversation

bigsheeper
Copy link
Contributor

This PR is a supplement to PR #30377.

pr: #30896

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 29, 2024
@czs007
Copy link
Collaborator

czs007 commented Feb 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (df16bf6) to head (001d299).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30913      +/-   ##
==========================================
+ Coverage   82.19%   82.20%   +0.01%     
==========================================
  Files         841      841              
  Lines      121457   121455       -2     
==========================================
+ Hits        99826    99842      +16     
+ Misses      18402    18381      -21     
- Partials     3229     3232       +3     
Files Coverage Δ
internal/util/importutil/json_handler.go 90.54% <100.00%> (ø)

... and 15 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 29, 2024
@sre-ci-robot sre-ci-robot merged commit 2f76303 into milvus-io:2.3 Feb 29, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants