Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] retry to read when the s3 get the unexpect eof error #30976

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Mar 1, 2024

issue: #30877
pr: #30861

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 1, 2024
Copy link
Contributor

mergify bot commented Mar 1, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Mar 1, 2024

/run-cpu-e2e

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 54.63918% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (ef84d40) to head (3a497ff).
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              2.3   #30976    +/-   ##
========================================
  Coverage   82.18%   82.18%            
========================================
  Files         843      843            
  Lines      121541   121687   +146     
========================================
+ Hits        99892   100012   +120     
- Misses      18421    18448    +27     
+ Partials     3228     3227     -1     
Files Coverage Δ
pkg/util/merr/errors.go 91.07% <ø> (ø)
pkg/util/retry/options.go 100.00% <100.00%> (ø)
pkg/util/retry/retry.go 100.00% <100.00%> (ø)
pkg/util/merr/utils.go 88.13% <40.00%> (-0.39%) ⬇️
internal/storage/remote_chunk_manager.go 68.52% <53.48%> (-0.76%) ⬇️
internal/storage/minio_chunk_manager.go 74.61% <50.00%> (-0.23%) ⬇️

... and 25 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added this to the 2.3.11 milestone Mar 4, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 4, 2024
@sre-ci-robot sre-ci-robot merged commit b0569f4 into milvus-io:2.3 Mar 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants