Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add GetSegments optimization to avoid meta mutex competition #31026

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Mar 5, 2024

pr: #31025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 5, 2024
Copy link
Contributor

mergify bot commented Mar 5, 2024

@zhagnlu Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/missing-related-pr labels Mar 5, 2024
Signed-off-by: luzhang <luzhang@zilliz.com>
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (a5350f6) to head (4de0535).
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31026      +/-   ##
==========================================
+ Coverage   82.20%   82.22%   +0.02%     
==========================================
  Files         843      843              
  Lines      121908   121915       +7     
==========================================
+ Hits       100214   100247      +33     
+ Misses      18461    18448      -13     
+ Partials     3233     3220      -13     
Files Coverage Δ
internal/datacoord/meta.go 88.75% <100.00%> (+0.11%) ⬆️
internal/datacoord/segment_manager.go 92.21% <100.00%> (+1.87%) ⬆️

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 5, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added this to the 2.3.11 milestone Mar 5, 2024
@sre-ci-robot sre-ci-robot merged commit 095c943 into milvus-io:2.3 Mar 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants